Bug Fix: Student has not started level message showing when not appropriate #31704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsbailey
reviewed
Nov 6, 2019
| if (config.hasContainedLevels) { | ||
| return false; | ||
| } else if ( | ||
| ['Gamelab', 'Applab', 'Weblab', 'Spritelab', 'Dance'].includes( |
There was a problem hiding this comment.
Sorry for the late comment, but I think we would also need some logic for artist and playlab levels which are project-backed, for example. These levels have a project_template_level_name. I checked on https://studio.code.org/s/express-2019/stage/7/puzzle/4 and I do not see the warning message regardless of whether the student has progress. It works fine on non-project-backed artist levels though. Opening as https://codedotorg.atlassian.net/browse/LP-983
There was a problem hiding this comment.
Oh nice find Dave! Thanks! I'm going to put that in next sprint as a follow-up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There were two different bugs with the "Student has not started this level" banner
Bug 1: Contained levels
The banner would always show on contained levels because the progress for a contained level is actually on the containee level instead of the container level. For now, this hides the banner for all contained levels as it should be obvious from the state of the level if it has been started or not (either they answered the question or not).
Bug 2: Dance party levels
The banner was showing on dance party levels because its a channel backed level type but it wasn't in the list of channel backed levels we were checking.
Links
Testing story
I added a UI test for checking that the banner does not show on a contained level.
I did not add a test for dance levels as I think there would be too many cases if we had a UI test for each level type. Instead, right now there is a test for just one channel backed level type and one non-channel backed level type.
Reviewer Checklist: