Put animated gif back because a UI test depends on it. #31743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revert the curriculum team's removal of an animated gif from Instructions in a level in Course 1 because a UI/Eyes test depends on it. The animated gif was removed for legitimate reasons, but is not urgent and can be reverted per the curriculum writer.
Future work
Clone the level into /s/allthethings, re-add the anigif into the cloned level, and update the test to reference the new level instead of live course content
Links
Log of test failing https://saucelabs.com/tests/e814540076da4d269fa1fae5589e88d6
Reviewer Checklist: