Teacher Homepage: HOC 2019 announcement #31821
Conversation
Also remove old unreachable and nonfunctional special announcement code - looks like it wasn't removed cleanly at some point in the past.
islemaster
changed the title
| "specialAnnouncementHeadingJoinProfessionalLearning2019Trophy": "Know an Awesome Teacher?", | ||
| "specialAnnouncementDescriptionJoinProfessionalLearning2019Trophy": "Let them know how amazing they are by nominating them for a Professional Learning Scholarship today!", | ||
| "specialAnnouncementHeadingHoc2019CsForGood": "The Hour of Code is coming", | ||
| "specialAnnouncementDescriptionHoc2019CsForGood": "Try one of the 100 NEW activities for the Hour of Code (Dec 9-15)! This year, encourage your students to think about ways of using CS for good. Sign up your class today.", |
There was a problem hiding this comment.
It turns out we're not using any of these specialAnnouncement strings anyplace anymore. Seems like we should remove them and put them back next year if needed? (Also, special announcements are constrained to English locales right now so no translation lead time to worry about.)
There was a problem hiding this comment.
That sounds good to me. Thanks for the extra clean-up here!
| hocLaunch={hocLaunch} | ||
| hasIncompleteApplication={!!sessionStorage['TeacherApplication']} | ||
| /> | ||
| <SpecialAnnouncementActionBlock hocLaunch={hocLaunch} /> |
There was a problem hiding this comment.
For US-centric stuff like teacher applications restricting to English makes sense. Do we want to remove the isEnglish check to show this HoC announcement in other languages too since it's relevant outside the US?
There was a problem hiding this comment.
I'm not sure - isn't CS Ed Week different in some other countries? I'll ask marketing.
| @@ -214,49 +214,26 @@ export class AdministratorResourcesActionBlock extends Component { | |||
|
|
|||
| export class SpecialAnnouncementActionBlock extends Component { | |||
| static propTypes = { | |||
| hocLaunch: PropTypes.string, | |||
| hasIncompleteApplication: PropTypes.bool | |||
| hocLaunch: PropTypes.string | |||
There was a problem hiding this comment.
Are we still using this hocLaunch prop for anything? I have a vague idea that it was for when we were doing short promos in succession last year (aquatic, then dance, etc). Just double checking it's still relevant.
There was a problem hiding this comment.
I'm leaving it in for now even though it's unused, because I believe we'll be doing some similar short promos this year.
|
Merged to get this change out for today. Am following up with Marketing re: making this visible to non-en locales. |
PLC-552 Adds the Hour of Code 2019 CS For Good announcement to the teacher dashboard homepage. We'd like to launch this today.
Also removes some old unreachable and partially nonfunctional special announcement code - looks like it wasn't removed cleanly at some point in the past, because the assets are missing.
Links
Testing story
Tested manually on local machine. Believe I've done due diligence checking that code and translations being removed are unused; otherwise leaning on CI to catch issues. I expect some eyes tests to change because of this.
Reviewer Checklist: