Download link for external videos & style tweaks #31833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erin007
commented
Nov 12, 2019
| @@ -31,8 +31,12 @@ | |||
|
|
|||
| - if video && use_large_video_player | |||
| .clear | |||
| .video-container.external-video-container | |||
| %a.btn.btn-large.btn-primary.next-stage.submitButton.pull-right= t('continue') | |||
| .video-container.external-video-container{{style: 'max-width: 970px; margin: auto'}} | |||
There was a problem hiding this comment.
I'd prefer not to use in-line styling, but wasn't sure where I could put this, especially if we don't want it to affect styles of other uses of these elements.
There was a problem hiding this comment.
what you have here seems good to me, given that it is a small amount of CSS. the alternative is to put this in application.scss, and scope it by limiting it to elements which match .video-container.external-video-container. breaking up our CSS is something on my list for optimizing our page load times, although it's getting a bit far down the list at this point.
There was a problem hiding this comment.
application.scss is kind of a beast - I see what you mean. Ok, I'll leave this here then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External video levels were a little mis-aligned LP-775 and they didn't have a download video button LP-774. So I added in the button, aligned elements on the page and per request from @fontie715 styled the "Download" button to be more consistent with the "Continue" button. I also added a little test update to ensure the "Download" button appears.
BEFORE:
AFTER:
