Assignment updates: confirmation dialog for assignment of hidden units #31899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ddenAssignment dialog
…dot-org/code-dot-org into confirm-assignment-of-hidden-units
dmcavoy
reviewed
Nov 14, 2019
| @@ -8,7 +8,7 @@ import i18n from '@cdo/locale'; | |||
| import Button from '@cdo/apps/templates/Button'; | |||
| import DropdownButton from '@cdo/apps/templates/DropdownButton'; | |||
| import BaseDialog from '@cdo/apps/templates/BaseDialog'; | |||
| import ConfirmAssignment from './ConfirmAssignment'; | |||
| import {ConfirmHiddenAssignment as ConfirmAssignment} from './ConfirmHiddenAssignment'; | |||
There was a problem hiding this comment.
Is this being used to confirm at hidden assignment or something else?
There was a problem hiding this comment.
Oh wait is this the old functionality that we will deprecate once the new features go out?
There was a problem hiding this comment.
Yes, AssignToSection will be deleted when the new feature goes out.
There was a problem hiding this comment.
should this be imported as just {ConfirmHiddenAssignment} now?
dmcavoy
approved these changes
Nov 14, 2019
davidsbailey
approved these changes
Nov 18, 2019
| @@ -8,7 +8,7 @@ import i18n from '@cdo/locale'; | |||
| import Button from '@cdo/apps/templates/Button'; | |||
| import DropdownButton from '@cdo/apps/templates/DropdownButton'; | |||
| import BaseDialog from '@cdo/apps/templates/BaseDialog'; | |||
| import ConfirmAssignment from './ConfirmAssignment'; | |||
| import {ConfirmHiddenAssignment as ConfirmAssignment} from './ConfirmHiddenAssignment'; | |||
There was a problem hiding this comment.
should this be imported as just {ConfirmHiddenAssignment} now?
| And I press the first ".uitest-assign-button" element | ||
| And I wait until element ".uitest-confirm-assignment-dialog" is visible | ||
| And I wait until element "#confirm-assign" is visible | ||
| And I press the first "#confirm-assign" element |
There was a problem hiding this comment.
did the assignment work? the suspense is killing me!
can you please check that #confirm-assign is gone, and .uitest-unassign-button is visible?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LP-1023
Currently if a teacher tries to assign a unit that they have previously hidden from the Edit Section Dialog, they see a confirmation dialog prompting them to unhide the unit before assigning:
This changes opens a similar dialog when a teacher tries to assign a previously hidden unit from the script or course overview page:
To accomplish this I renamed the
ConfirmAssignmentcomponent toConfirmHiddenAssignmentand modified it to only handle this case because we are no longer using the confirmation dialog to confirm any other type of assignment. To populate the message in the dialog I needed to pass sectionName and assignmentName into theAssignButtoncomponent which handles when the dialog is displayed.I added a UI test to ensure that the confirmation dialog opens when it should and "unhide and assign" works correctly. (However, this file of tests is currently being skipped because it's flaky, but it's a good start for when I re-enable).