[student-libraries] Allow exporting nested libraries #31971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmkulwik
changed the title
ajpal
reviewed
Nov 21, 2019
| @@ -100,11 +100,17 @@ class LibraryCreationDialog extends React.Component { | |||
| this.setState({publishState: PublishState.NO_FUNCTIONS}); | |||
| return; | |||
| } | |||
| let librarySource = response.source; | |||
| response.libraries && | |||
There was a problem hiding this comment.
nit: I think this would be clearer as if (response.libraries) {...}
ajpal
reviewed
Nov 21, 2019
| let libraryName = 'name'; | ||
| let source = 'function foo() {}'; | ||
| beforeEach(() => { | ||
| getJSLintAnnotationsStub = sinon.stub( |
There was a problem hiding this comment.
nit: I'm not sure if there's a better name, but getJSLintAnnotationsStub to me reads like it's a function to get a stub for JSLintAnnotations
There was a problem hiding this comment.
I tried finding a better name, but couldn't come up with anything (stubGetJSLintAnnotations has the same problem). I'm going to leave it as-is.
ajpal
approved these changes
Nov 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, students who exported a library that used a different library would cause breaks in projects that imported their library. This fixes that issue. Students can now import a library into a project and publish that project as a library.
Links
Testing story
Updated tests
Reviewer Checklist: