Assignment Updates: unassign from course overview #31977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
are we sure we want to unassign the course when we unassign the unit? just asking since it doesn't specify in the jira item |
davidsbailey
approved these changes
Nov 18, 2019
I can see it both ways. I think because assigning a unit also assigns the course it is in (where applicable), and unassigning a course unassigns any assigned units keeping unassignment of a unit consistent by also unassigning the course makes sense. I'm inclined to see how confusing this is for teachers and update later if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LP- 1030
Currently with the
assignmentUpdatesexperiment flag enabled, a teacher can assign a unit from the course overview page. However, they can't unassign that unit because for both students and teachers, we're showing the assigned checkmark.This update allows teachers to unassign units from the course overview page.
