Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide named checkbox #31978

Merged
merged 3 commits into from Nov 19, 2019
Merged

Hide named checkbox #31978

merged 3 commits into from Nov 19, 2019

Conversation

davidsbailey
Copy link
Member

@davidsbailey davidsbailey commented Nov 18, 2019

Description

finishes LP-752

By default, each level in a stage appears as a bubble in a row without any special name:

Screen Shot 2019-11-18 at 2 05 56 PM

If you want to give a lesson or group of lessons a name, you do so via named or progression:

script overview page:
Screen Shot 2019-11-18 at 2 07 19 PM

script edit gui page:
Screen Shot 2019-11-18 at 2 13 21 PM

when using the named checkbox, you also have to go into each level and specify the display_name there: https://github.com/code-dot-org/code-dot-org/blob/24eb3b0b9731c75a818cd9714b76fd91ce63b8d8/dashboard/config/scripts/levels/CSD%20U2L04%20TFMD_2019.level#L9-L8

Because you can accomplish the same goal more easily by just specifying a progression name on the one level you want to name, this PR deprecates the named checkbox by hiding it in the edit UI unless it was already in use:

Screen Shot 2019-11-18 at 2 17 51 PM

it also reorders the checkboxes, but that shouldn't matter because no one is using this UI yet.

Testing story

verified end-to-end manually (see screenshots). updated existing unit test to verify absence of named checkbox. existing tests cover presence of named checkbox.

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@davidsbailey davidsbailey marked this pull request as ready for review November 18, 2019 22:03
Copy link
Contributor

@Erin007 Erin007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder about the tooltip text. Is it worth adding in the "named" tooltip that this deprecated and progression should be used? It might be confusing to see a reference to the "named" checkbox in the progression tooltip when there isn't a named checkbox. Otherwise, LGTM!

@davidsbailey
Copy link
Member Author

Great idea! I removed the mention of the named checkbox from the progression tooltip, and if people follow the suggestion in the named tooltip when they see it then they should be good.

@davidsbailey davidsbailey merged commit ffb6b48 into staging Nov 19, 2019
@davidsbailey davidsbailey deleted the hide-named-checkbox branch November 19, 2019 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants