Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show locale dropdown on Spritelab #31997

Merged
merged 2 commits into from Nov 19, 2019
Merged

Show locale dropdown on Spritelab #31997

merged 2 commits into from Nov 19, 2019

Conversation

bethanyaconnor
Copy link
Contributor

Screenshot 2019-11-19 at 8 42 07 AM

Description

Spritelab is translateable and many levels are translated. We should show the language dropdown to avoid confusion.

Links

Testing story

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@bethanyaconnor bethanyaconnor merged commit 6964d7a into staging Nov 19, 2019
@bethanyaconnor bethanyaconnor deleted the show-locale-on-spritelab branch November 19, 2019 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkiruka nkiruka nkiruka approved these changes

@ajpal ajpal Awaiting requested review from ajpal

@dju90 dju90 Awaiting requested review from dju90

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bethanyaconnor @nkiruka