Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move dance 2018 scripts to the end of the list #32030

Merged
merged 1 commit into from Nov 20, 2019
Merged

Conversation

davidsbailey
Copy link
Member

@davidsbailey davidsbailey commented Nov 20, 2019

Description

Finishes https://codedotorg.atlassian.net/browse/LP-1039

Now that we have dance-2019 and dance-extras-2019, the dance and dance-extras courses from 2018 need to be moved to the end of the Hour of Code section in this dropdown:

Screen Shot 2019-11-20 at 10 29 01 AM

The other changes requested in the Jira item have been made via levelbuilder UI.

Testing story

Updated existing tests enforcing the order in the assignment dropdown.

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@davidsbailey davidsbailey merged commit fc7bccf into staging Nov 20, 2019
@davidsbailey davidsbailey deleted the move-dance-2018 branch November 20, 2019 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants