Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch back to 'copy and remove' strategy for sync out #32042

Merged
merged 1 commit into from Nov 21, 2019
Merged

switch back to 'copy and remove' strategy for sync out #32042

merged 1 commit into from Nov 21, 2019

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Nov 20, 2019

Description

Fixes a bug added in #31771; specifically, FileUtils.mv will complain if there are existing directories that would be overridden by the operation, while cp_r can recursively deal with duplicates, which is the desired behavior.

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@Hamms Hamms requested review from daynew and nkiruka November 20, 2019 23:11
@Hamms Hamms requested a review from a team as a code owner November 20, 2019 23:11
@Hamms Hamms merged commit 03da5a4 into staging Nov 21, 2019
@Hamms Hamms deleted the sync-out-copy branch November 21, 2019 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkiruka nkiruka nkiruka approved these changes

@daynew daynew Awaiting requested review from daynew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hamms @nkiruka