dont add newlines when replacing editor experiment #32087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsbailey
force-pushed
the
editor_experiment_newline
branch
from
d8367d2
to
6b6a710
Compare
dmcavoy
approved these changes
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-on to #32017
there seem to be a number of blank lines accumulating in DSL-defined level files after the
editor_experimentline. This PR attempts to fix that by removing the preceding newline. Note that this might fail to remove aneditor_experimentis on the very first line of the file, but that seems unlikely and (though confusing) would be mostly harmless since it'd be overridden by theeditor_experimentwe then added on the second line of the file.Testing story
updated existing unit test cases.
Reviewer Checklist: