Fish: Fix the layout of the rotate device UI #32115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rotate device UI, shown on narrow devices when in portrait layout, was now showing correctly for the fish app. Calling one extra function normally called by studioApp.init() fixes up the viewport so that it looks correct.
breville
requested review from
cpirich,
maddiedierker,
bethanyaconnor and
simplycloud
bethanyaconnor
approved these changes
Nov 24, 2019
maddiedierker
approved these changes
Nov 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rotate device UI, shown on narrow devices when in portrait layout, was not showing correctly for the fish app. Calling one extra function normally called by
studioApp.init()fixes up the viewport so that it looks correct.before
after
The slightly overlap between text and image is consistent with what's currently on production.