[Applab Datasets] Fix off-by-one error in upload scripts #32175
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ids for the purpose of the Data Tab are 1-indexed. I had set the id on each record correctly, but put them all in an array (0-indexed) and set them in firebase that way. As a result, the id on each record, did not match the id of the firebase node. This resulted in off-by-one errors when trying to edit or delete records
Before:
After:
Testing story
Reviewer Checklist: