New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update circuit playground discount code applications for 2020 #32179
Merged
bencodeorg
merged 35 commits into
staging
from
update-circuit-playground-discount-codes
Dec 21, 2019
Merged
Changes from 19 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
b127918
Set high needs bar to 50%
bencodeorg 8efab7e
Merge branch 'staging' into update-circuit-playground-discount-codes
bencodeorg 21413d9
Non-i18n String changes for 19-20 Adafruit discount codes
bencodeorg 4880ad5
More i18n updates for Adafruit discount codes
bencodeorg 310e549
Add option for discount code with shipping to Alaska and Hawaii
bencodeorg 3cc3cd3
Correct logic for discount codes with and without shipping
bencodeorg 8e8fdba
Check for teacher attendance at Q4 workshop
bencodeorg 21e19ac
Model changes to check for Q4 workshop attendance for discount code e…
bencodeorg 26d49b4
Check Unit 6 intention appropriately
bencodeorg 278ebd3
Consistent variable naming in discount application model
bencodeorg 0c9ea08
Make long string prettier
bencodeorg 6c0535d
Update tests to cover 2020 discount code application requirements
bencodeorg 0402a4d
Update storybook components for 2020 discount codes
bencodeorg 8e8e0e2
Update apps tests
bencodeorg 411d349
More apps test updates for 2020 discount codes
bencodeorg 7d03566
Update discount logic apps test
bencodeorg a2b4791
Fix more dashboard discount code tests
bencodeorg 1d89206
Fix school tests to account for new high needs bar
bencodeorg de64b40
Fix enum in circuit playground discount application
bencodeorg c2d691d
Attendance at virtual workshop 8 counts for discount eligibility
bencodeorg 92d8727
Add string to alert AK/HI teachers about shipping
bencodeorg 3a8e9e6
Separate discount code type from school eligibility
bencodeorg 2f858df
Give full discount to teachers in Alaska and Hawaii
bencodeorg e573d65
Remove unnecessary new language about AK/HI
bencodeorg 3568e5c
Keep old options in enum for Unit 6 intention responses
bencodeorg ef1c2ea
Use refute instead of assert_equal for false test
bencodeorg b55117b
Require workshop subject when checking PD eligibility
bencodeorg 58d0f22
String update for 2020
bencodeorg 68fbb17
Merge branch 'staging' into update-circuit-playground-discount-codes
bencodeorg 9a40301
Pull commit made via GitHub UI
bencodeorg a7d307b
Add documentation to check on PD attendance method
bencodeorg 0b53924
Update storybooks and JS unit tests
bencodeorg 1c4d7a5
Update factories and tests for maker controller updates
bencodeorg 0098b70
Allow application status check for application with no school
bencodeorg 582465b
Merge staging
bencodeorg File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add stories to this file for the scenario where the academic year PD requirement has not been passed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!