DTL (Test > Levelbuilder): b6481697 #32225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We decided to go back to using the old layout for non-en locales when showing the locale-specific set of tutorials. This leaves the other small improvements in #30923 in place, though.
In the new Oceans script, the device rotation image shown on portrait layout was not showing properly. This is a fix for that issue targeted at the Oceans script, but it could be generalised later, since this apparently happens for other tutorials too. On an actual iPhone, this view is scrollable. In Chrome's device mode it's not, but the issue is otherwise the same. The issue here is that the viewport's dimensions and scaling have made the viewport bigger than the physical screen. The fix is fairly simple in this case. We know that the Oceans tutorial can scale down to 480px wide, and so we set the viewport to be 600px wide. We also set the scaling on the viewport so that the 600px is what's displayed on the screen. We also adjust the scaling on the rotation image to fill that space.
…unexpected exceptions in generation
…-oceans-image Revert "Revert "Oceans Landing: tutorial banner with swimming fish""
Fixes for oceans social share
Oceans Landing: behind the scenes
[DO NOT MERGE UNTIL 12/2] Oceans: teacher homepage oceans announcement
Update oceans video
Make oceans script assignable
Add HoC cert generation exception handling
Csforgood image on hourofcode/overview
Bump ml-activities to 0.0.19
Add logic for AI for Oceans custom certificate
Update social image for code.org
…ocalization Fix function name localization
added strings for AI for Oceans
DTT (Staging > Test) [robo-dtt]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.