When clicking "Print One Here" on /certificates, use the same certificate as is displayed #32246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breville
approved these changes
Dec 3, 2019
Erin007
approved these changes
Dec 3, 2019
|
Not for this PR, but we should track localizing the strings on this page. Is that FND since it's i18n? |
|
Good catch! It should be owned by whoever owns code.org/certificates but I'm not sure who that is. I might just fix it today though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you go to https://code.org/certificates?script=oceans you see the custom certificate associated with the oceans script
However, prior to this change, when you click "Print One Here", you're directed to https://code.org/images/hour_of_code_certificate.jpg. Instead we should direct to the certificate displayed.
Links
Testing story
Reviewer Checklist: