New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n for "AI for Oceans" activity #32362
Conversation
I am concerned about step 5; that process is currently undefined for our Blockly I18n, and I'd really like to make sure we have a solid plan for how to address that (for both this and Blockly, ideally) before we commit to this pattern. |
Yeah, I don't love the pattern we have for Blockly and I wasn't super excited to commit harder to it. Open to thoughts on better ways to handle this. However, I don't fully understand what your question is. What is undefined? |
@Hamms after our discussion last week, any feedback on this PR? I think this goes in the general direction we talked about on Friday |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I'm excited to see how this approach works in practice and to update our blockly i18n strategy to match
I'm bumping |
Description
Relies on a merge and publish of code-dot-org/ml-activities#343.
This approach is based off how we do i18n in Blockly. In
ml-activities
, we will expose a json of the strings we use. Our i18n pipeline will copy that file into the source directory and sync it to Crowdin.Because we currently don't have any other
fish
strings, I'm copying theml-activities
source strings toi18n/locales/source/blockly-mooc/fish.json
which will mean (after a full sync), translations will end up inapps/i18n/fish/<lang>.json
which should allow translations to "just work". However, if we ever add strings to this activity directly in this repo, we'll need to change this approach (it will overwrite any string).Open to thoughts/suggestions on this approach.
Full process for translating
ml-activities
stringsIn the
code-dot-org
repo, we useMessageFormat
in our apps code. This repo will use the same version. The steps the strings will go through to be translated are:oceans.json
apps/i18n/fish/<lang>.json
Reviewer Checklist: