Unify i18n logic in the various Craft apps #32375
Conversation
…, since they are all ultimately using the same locale file
|
To make sure I understand — this de-dups the localization across the four Craft variants, and merges all the strings into one file? Did you programmatically build the superset or create it by hand? |
apps/test/unit/craft/i18nTest.js
Outdated
| @@ -0,0 +1,30 @@ | |||
| import {assert} from '../../util/deprecatedChai'; | |||
There was a problem hiding this comment.
Any reason not to use reconfiguredChai?
There was a problem hiding this comment.
no idea! I was just copying what's in the existing craftTest
precisely!
Bit of both; I copied all objects into one, sorted the keys by name, and deleted duplicates. |
|
Ah, cool. Looks like the end result was exactly the same as what the "agent" version had:
|
There was a problem hiding this comment.
LGTM! Sorry for missing this the first time around.
Ah, cool. Looks like the end result was exactly the same as what the "agent" version had:
This seems strange at first, but can probably be explained if each subsequent minecraft copied the previous one's locale file and then added to it.
Description
Follow-up to #32136
Right now, all the Craft apps share the same i18n file, but each one also references that file independently and reimplements a bunch of shared logic around i18n. This change brings all shared i18n code up one level to be used by all Craft apps equally.
Links
Reviewer Checklist: