Create report dialog #32382
Merged
Create report dialog #32382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erin007
reviewed
Dec 12, 2019
| }; | ||
|
|
||
| export class LessonStatusList extends Component { | ||
| static propTypes = {}; |
There was a problem hiding this comment.
is this here in anticipation of the propTypes we'll need when we connect to real data?
There was a problem hiding this comment.
Yup! I figure we will at somepoint want to get the lesson list and status of the lessons from redux/props so I just left it there.
Erin007
approved these changes
Dec 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creates a new component for the CreateStandardsReportDialog for the standards page in the progress tab of Teacher Dashboard. This is just created in storybook right now and not connected to anything. The component has two pages which are also components.
Also in order to reuse parts of the LessonStatusDialog I broke out at LessonStatusList to be used in both the LessonStatusDialog and CreateStandardsReportDialog.
Links
Testing story
Created a storybook entry for the component. Will add further testings once the component is connected to other components.
Reviewer Checklist: