Update weather script #32384
Update weather script #32384
Conversation
| WeatherRecord = Struct.new(:id, :city, :state, :timestamp, :temp_min, :temp_max, :weather, :icon, :wind_speed) | ||
|
|
||
| def cardinal_dir_from_degrees(degrees) | ||
| dirs = %w(N NE E SE S SW W NW N) |
There was a problem hiding this comment.
Is it intentional that N is in here twice?
There was a problem hiding this comment.
Oh, I see. For 0 and 360.
There was a problem hiding this comment.
Ok, second question. Is it ever possible to get degrees above 360 or below 0?
There was a problem hiding this comment.
Yes, intentional for N twice, for 0 and 360 as you said :)
I don't think the API response will ever have numbers outside that range.
There was a problem hiding this comment.
Ok. What about error input? If degrees is "nil" or something similar, will it cause the script to error out and exit early? Is that ok?
bin/cron/applab_datasets/weather
Outdated
| @@ -165,6 +197,7 @@ end | |||
| def main | |||
| fb = FirebaseHelper.new('shared') | |||
| records, columns = get_weather_data | |||
| fb.delete_shared_table('weather') | |||
| fb.upload_shared_table('weather', records, columns) | |||
There was a problem hiding this comment.
Is there a possibility that students querying the weather table will get nothing because it's been deleted but not re-uploaded? Is this a problem?
There was a problem hiding this comment.
If someone happens to be looking at the table when the script is run (once per day), then yes I think they will see nothing for a fraction of a second. But then the new data will pop in automatically when the new table is uploaded. To me that doesn't seem like a big deal, especially for v1, but what do you think?
There was a problem hiding this comment.
✔️ ^ I agree. Since it auto-populates, it's not a big deal.
There was a problem hiding this comment.
✔️ ^ I agree. Since it auto-populates, it's not a big deal.
| "cats", | ||
| "dogs", | ||
| "states", | ||
| "weather", |
There was a problem hiding this comment.
Did you intend to keep weather?
Description
Switch to using the daily API per curriculum request: https://openweathermap.org/forecast16
Before:
After:
Testing story
Manual testing only
Reviewer Checklist: