Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent export applab app to expo with data apis #32386

Merged
merged 2 commits into from Dec 13, 2019
Merged

Prevent export applab app to expo with data apis #32386

merged 2 commits into from Dec 13, 2019

Conversation

cpirich
Copy link
Contributor

@cpirich cpirich commented Dec 11, 2019

Description

  • We've decided to prevent exporting applab apps that use data APIs during our beta period, so we can understand the degree of demand for the functionality and give ourselves time to partition exported app Firebase data separately.
  • This is a targeted change to disable this with a helpful error message. The existing codepath is retained under a new exportExpoWithData experiment.

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

cpirich
cpirich commented Dec 11, 2019
View reviewed changes
apps/src/code-studio/components/ExportDialog/Dialog.jsx
: 'Failed to create app. Please try again later.';
recordExport(
hasDataAPIsError ? 'publishBlockedDueToDataAPIs' : 'publishToExpoError'
);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will now distinguish this case so we can use the firehose data to determine how often project exports are being blocked for this reason.

islemaster
islemaster approved these changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good.

@cpirich cpirich merged commit 02139c3 into staging-next Dec 13, 2019
@cpirich cpirich deleted the cpirich/prevent-export-applab-app-to-expo-with-data-apis branch December 13, 2019 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@islemaster islemaster islemaster approved these changes

Assignees
No one assigned
Labels
star-labs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cpirich @islemaster