Disallow behavior editing if there is a toolbox with no categories #32395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems like a workaround for a very specific use-case. Is there future work planned to allow levelbuilders to enable/disable the edit behavior button per level? |
I don't think so at this point? This was the decision from the curriculum/eng meeting: https://docs.google.com/document/d/1EL99K31sSv3wwsfc5bNqtChh870oF3GepenWxyPm9Cg/edit#bookmark=id.swq3i21lhwkw |
jmkulwik
reviewed
Dec 18, 2019
| @@ -377,7 +378,12 @@ export default { | |||
| .appendTitle(fieldLabel, 'VAR') | |||
| .appendTitle(Blockly.Msg.VARIABLES_GET_TAIL); | |||
|
|
|||
| if (Blockly.useModalFunctionEditor) { | |||
| let allowBehaviorEditing = Blockly.useModalFunctionEditor; | |||
| if (appOptions.level.toolbox && !Blockly.hasCategories) { | |||
There was a problem hiding this comment.
Can you add a comment explaining why we do this check? (No need to wait for drone after)
jmkulwik
approved these changes
Dec 18, 2019
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for #32252, which was reverted by #32280
Level with categorized toolbox (allows behavior editing):
s/coursef-2019/stage/3/puzzle/5
Level with no toolbox (allows behavior editing):
s/coursef-2019/stage/15/puzzle/2
Level with uncategorized toolbox (disallows behavior editing):
s/coursef-2019/stage/2/puzzle/4
Links
Testing story
Reviewer Checklist: