Standards toggle only shows for CSF courses #32430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmcavoy
reviewed
Dec 17, 2019
| @@ -68,4 +70,16 @@ describe('SectionProgress', () => { | |||
| ); | |||
| expect(wrapper.find('#uitest-detail-view').exists()).to.be.true; | |||
| }); | |||
|
|
|||
| it('standards view shows standards view and legend', () => { | |||
There was a problem hiding this comment.
the name here seems a little confusing. The legend is part of the standards view right? Should it explicitly check for the legend or is it just checking for the whole standards view?
dmcavoy
reviewed
Dec 17, 2019
| @@ -3,6 +3,8 @@ import {shallow} from 'enzyme'; | |||
| import {expect} from '../../../util/deprecatedChai'; | |||
There was a problem hiding this comment.
can you update this to reconfigedChai while we are here?
dmcavoy
approved these changes
Dec 17, 2019
clareconstantine
approved these changes
Dec 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spec
LP-957 Part 1
The new Standards view of the progress tab will only be applicable to CSF courses (Course A-F, Pre-Express and Express), therefore we need to hide that tab in the toggle for all other selections.
excludeCsfColumnInLegendis already being used to distinguish CSF courses from other types of assignables, so I'm re-using it here to conditionally hide/show the Standards toggle.Up next is handling the case where the teacher switches from a CSF course -> non-CSF course while on the standards tab. Currently the standards tab disappears, but the content of the standards tab remains, instead the teacher should be taken to “Lessons” for the newly selected course.