Show workshop created_at date on workshop dashboard #32453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failure is |
islemaster
force-pushed
the
workshop-created-at
branch
from
8a0b910
to
e5b7ec3
Compare
hacodeorg
approved these changes
Dec 18, 2019
| @@ -405,6 +405,13 @@ class Api::V1::Pd::WorkshopsControllerTest < ::ActionController::TestCase | |||
| assert_response :forbidden | |||
| end | |||
|
|
|||
| test 'created_at is included in a serialized workshop response' do | |||
There was a problem hiding this comment.
This attribute is getting special treatment :) If we have to do this more often, we can consolidate all serialization tests in a WorkshopSerializerTest class.
islemaster
added a commit
that referenced
this pull request
Dec 20, 2019
Restores behavior introduced in #32453 and regressed during a complicated rebase in #31990. Most of the change was preserved, but the JSX that actually renders the new component was accidentally dropped. I mentioned in the previous PR that I wasn't adding a test for the UI because I was adding so many tests in the other PR (that regressed this!) and it would be covered. Turns out I was wrong! So now I'm adding a unit test for the Workshop component that verifies that we show the created_at date as expected.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Megan mentioned that she needs to look up the
created_atfield for a workshop a handful of times a year. Rather than handle these requests manually, it seems reasonable to add this metadata in an understated style to the end of the workshop view.Testing story
Unit tests for the update to the workshop serializer. Manually tested the client change. The only reason I'm not adding unit tests here is that there are no unit tests for the workshop view right now but I'm adding a bunch of them in #31990 and they'll cover this new code path.
Reviewer Checklist: