Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to last year's dance party tutorial on /dance #32471

Merged
merged 3 commits into from
Dec 18, 2019

Conversation

molly-moen
Copy link
Contributor

@molly-moen molly-moen commented Dec 18, 2019

Description

PLC-643: add a link to last year's dance party tutorial on the /dance page, right aligned.
New text:
image

Visible on desktop and mobile:
image

image

Background

This change was added and reverted back in November. It was reverted because there was an issue rendering markdown in staging--that has been investigated and found to be isolated to staging, and the issue has been fixed. There was also discussion at the time about the amount of whitespace below the text, so I updated the padding to have the same amount of whitespace between the new text and the "In partnership" section as there previously was between the boxes and the "In partnership" section.
For reference, here are the desktop and mobile views without the text:
image

image

Testing story

This is a content change, tested locally. This will also cause a diff in tutorial_landing_pages.feature.

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for picking this up!

@molly-moen molly-moen merged commit 94163ee into staging Dec 18, 2019
@molly-moen molly-moen deleted the revert-32198-remove-dance-last-year-links branch December 18, 2019 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants