New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Blockly blocks to Content levels. #32484
Conversation
// Install the common Blockly blocks | ||
commonBlocks.install(window.Blockly, {}); | ||
// Install the custom CDO blocks for the following level/app types. | ||
var options = [{skin: {id: 'birds'}, app: 'maze'}, {skin: {}, app: 'turtle'}]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note this is inconsistent with the above comment, which claims that we are making all the apps available.
I don't think I'm in favor of this approach; in particular, the existing app-specific locale files are not intended to be used together and there is no guarantee that they won't have conflicts. I'd recommend that we install only the common blockly blocks for now, and as follow-up work look into either adding an app association to content levels or unifying the app locales in general.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/locale/block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From our conversation offline, I have created TODO's and a follow up JIRA task which we will get prioritized for Jan 2020.
https://codedotorg.atlassian.net/browse/FND-972
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I talked with Bryan and found out he is mostly interested in being able to render Turtle Blockly blocks. So I have removed the second level type "maze" from the blocks imported. This way we don't have to do cleanup in January and we will still do the dynamic level type loading later in H1.
3cbb24e
to
2a8fc35
Compare
In Content levels, such as External levels, level creators were taking screenshots of Blockly blocks and adding them to the instructions in order to give a preview to the student of what the blocks look like. This has become a problem because screenshots are not translatable and we are expanding our content to be used internationally. * Added common, maze, and turtle CDO blocks to Content levels. * <xml> blocks in Markdown content render as Blockly blocks.
2a8fc35
to
f3e04d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for following up on the 'multiple block types' thing, I'm much happier with where we landed.
This is so cool!! Remember always wanted to support this 😄 |
Description
In Content levels, such as External levels, level creators were taking
screenshots of Blockly blocks and adding them to the instructions in
order to give a preview to the student of what the blocks look like.
This has become a problem because screenshots are not translatable and
we are expanding our content to be used internationally.
Screenshots
Example of translations working
Working examples of all the existing screenshots used in External levels.
Links
Testing story
Reviewer Checklist: