Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use content_tag rather than string interpolation to safely build HTML element #32514

Merged
merged 1 commit into from Dec 20, 2019
Merged

Use content_tag rather than string interpolation to safely build HTML element #32514

merged 1 commit into from Dec 20, 2019

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Dec 20, 2019

Description

Updates match_answer_as_image to work the same as match_answer_as_embedded_blockly and match_answer_as_iframe

Prereq for https://codedotorg.atlassian.net/browse/FND-904

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@Hamms
Use content_tag rather than string interpolation to safely build HTML…
0ed9c43 
… element

Updates `match_answer_as_image` to work the same as `match_answer_as_embedded_blockly` and `match_answer_as_iframe`

Prereq for https://codedotorg.atlassian.net/browse/FND-904
davidsbailey
davidsbailey approved these changes Dec 20, 2019
View reviewed changes
Copy link
Member

@davidsbailey davidsbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - I'm not familiar with content_tag, but the unit test makes this quite understandable!

@Hamms Hamms merged commit 8ea6ee6 into staging Dec 20, 2019
@Hamms Hamms deleted the render_multi_or_match_content-use-content-tag branch December 20, 2019 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsbailey davidsbailey davidsbailey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hamms @davidsbailey