Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch back to mainline i18n gem #32567

Merged
merged 1 commit into from Feb 14, 2020
Merged

switch back to mainline i18n gem #32567

merged 1 commit into from Feb 14, 2020

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Jan 7, 2020

Description

Both ruby-i18n/i18n#423 and ruby-i18n/i18n#422 have been in mainline for a while, so we no longer need to maintain our own version.

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@Hamms Hamms requested a review from wjordan January 8, 2020 01:02
@Hamms Hamms marked this pull request as ready for review January 8, 2020 01:02
wjordan
wjordan approved these changes Feb 14, 2020
View reviewed changes
Copy link
Contributor

@wjordan wjordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Hamms Hamms merged commit a18d14c into staging Feb 14, 2020
@Hamms Hamms deleted the mainline-i18n-gem branch February 14, 2020 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjordan wjordan wjordan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hamms @wjordan