Update the name of the flag we use for specificity #32575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not blocking: Can you put the experiment names you're using as constants here? https://github.com/code-dot-org/code-dot-org/blob/staging/apps/src/util/experiments.js#L20 |
ajpal
approved these changes
Jan 8, 2020
maddiedierker
approved these changes
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To prep for the BETT Demo, I'm swapping out the name of the experiment flag from 'microbit' to 'bett-demo'. Being more specific with the flag string will make it easier to scope the changes that are behind this flag and easily deprecate the flag after the demo (useful as we move our changes from 'demo-ready' to 'release-ready').
Testing story
Reviewer Checklist: