Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title logging #32585

Merged
merged 3 commits into from Jan 13, 2020
Merged

Title logging #32585

merged 3 commits into from Jan 13, 2020

Conversation

clareconstantine
Copy link

@clareconstantine clareconstantine commented Jan 8, 2020

Description

As a followup to #32269, move the logging for WebPurify/Geocoder errors in our profanity/privacy filtering to Firehose. We've been using slog, which is not the current preferred place for logging.

More info on slog:

Open Question: Should I move the other "slogging" in this file to Firehose as well? https://github.com/code-dot-org/code-dot-org/blob/staging/dashboard/app/controllers/activities_controller.rb#L128

Links

Testing story

Updated activities_controller.rb unit tests to reflect the new logging.

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@islemaster
Copy link
Contributor

Further history of slog: It stands for "structured logging," and was added by @geoffrey-elliott back in 2014 (before the history of our current repo). Apparently these do (or did) flow into a service called Logentries for later analysis.

We've still got this five-year-old comment on the activity monitor:

# Currently data is sent to LogEntries for collection and collation via TCP-based log. This
# script collects a 4 hour period worth of data, analyzes it, and reports.
#
# FUTURE THOUGHTS: This is the only reason we use LogEntries. We could probably just use a
# an RDS database, MongoDB, or even just a regular log file and eliminate the cost of
# LogEntries.

At this point I'm not sure anyone still looks at Logentries, or even has access to it - I'm asking the team now.

Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel good about this change, but no pressure to go clean up other instances of slog for now.

@clareconstantine clareconstantine merged commit 3e39dc8 into filter-project-titles Jan 13, 2020
@clareconstantine clareconstantine deleted the title-logging branch January 13, 2020 22:13
@clareconstantine clareconstantine mentioned this pull request Jan 13, 2020
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants