Standards Report: Progress box tooltips #32589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmcavoy
approved these changes
Jan 9, 2020
| lessonNumber={lesson.lessonNumber} | ||
| /> | ||
| <span> | ||
| <ReactTooltip |
There was a problem hiding this comment.
Could we move the ReactTooltip inside ProgressBoxForLessonNumber?
There was a problem hiding this comment.
Sounds good! I moved the tooltips and added lesson to a new standards shapes file.
There was a problem hiding this comment.
Wait - I don't think we actually want the tooltip to live inside the ProgressBoxForLessonNumber component because we'll use that component in the dialogs where we don't want it to have a tooltip.
There was a problem hiding this comment.
Ya makes sense we wouldn't want them there. Good catch!
…ment in the interator will have a unique identifier and storybook will be happy
Erin007
force-pushed
the
progress-box-tooltips
branch
from
0dd29ad
to
befdbff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LP-962 && LP-1128
Spec
This adds tooltips to the progress boxes that will be displayed on the standards view of the progress tab. They include the lesson name, completion status and # of students out of the total # in the section who have completed the lesson.
And links the progress box to the lesson plan on curriculum.code.org
Right now, this is all fake data.