[student-libraries] Allow renaming a library when creating/publishing it #32599
Conversation
| "libraryExportNoCommentError": "This function cannot be exported until you add a comment to it.", | ||
| "libraryExportTitle": "Export Functions as a Library", | ||
| "libraryName": "Library Name:", | ||
| "libraryName": "Library Name", | ||
| "libraryNameRequirements": "Your library's name must start with a capital letter and use only letters, numbers, and underscores.", |
There was a problem hiding this comment.
note that many languages have no concept of capital letters
There was a problem hiding this comment.
I believe this came from a desire to teach good naming conventions.
There was a problem hiding this comment.
Oh you mean written/spoken languages - not programming languages.
There was a problem hiding this comment.
Great point. I'll circle back with curriculum and prod on that one.
| export function suggestName(libraryName) { | ||
| let suggestedName = sanitizeName(libraryName); | ||
| if (suggestedName.length === 0 || !isNaN(suggestedName.charAt(0))) { | ||
| suggestedName = 'Lib' + suggestedName; |
There was a problem hiding this comment.
Is this okay for non-English libraries?
There was a problem hiding this comment.
Hmmm great question. I'll circle back with the curriculum & prod teams on that one.
|
RE: Comments regarding internationalization. I've started a thread with curriculum & prod, but I don't think this should block this PR because as these issues are not introduced by this PR and will be straightforward to update/fix when answers come in. I've scheduled that work as followup. |
Description
OLD:
NEW:
Links
Testing story
Reviewer Checklist: