Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PD Application Banners #32629

Merged
merged 1 commit into from
Jan 13, 2020
Merged

Add PD Application Banners #32629

merged 1 commit into from
Jan 13, 2020

Conversation

molly-moen
Copy link
Contributor

Description

Add banners to homepage and https://code.org/educate/professional-learning/middle-high that notify teachers that applications are open:
homepage:
Screen Shot 2020-01-10 at 2 18 05 PM

/middle-high if teacher is not nominated:
Screen Shot 2020-01-10 at 2 05 55 PM

/middle-high if teacher is nominated:
Screen Shot 2020-01-10 at 2 05 45 PM

homepage on mobile size:
Screen Shot 2020-01-10 at 2 20 27 PM

middle-high on mobile size:
Screen Shot 2020-01-10 at 2 21 43 PM

Links

Testing story

Validated banners look correct on different sizes and browsers.

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

Copy link

@agealy agealy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for moving quickly and separating these out into their own PR! Let's just make sure they don't go out before Monday's DTP

Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@molly-moen molly-moen merged commit efc3721 into staging Jan 13, 2020
@molly-moen molly-moen deleted the molly/application-banners branch January 13, 2020 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants