Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Don't show tts button until audio is playable"" #32639

Merged
merged 2 commits into from
Jan 15, 2020

Conversation

maddiedierker
Copy link
Contributor

@maddiedierker maddiedierker commented Jan 13, 2020

Reverts #32634, re-implementing #31089

Now that we check the audio src every time the <InlineAudio/> component mounts, a bug was uncovered where when we receive message text as the audio source, we aren't checking if we actually have a voice for that locale before creating a src URL (relevant New Relic error). Bug is fixed in 0d254aa

@maddiedierker maddiedierker merged commit 8d4d80d into staging Jan 15, 2020
@maddiedierker maddiedierker deleted the revert-32634-revert-31089-oct3-tts branch January 15, 2020 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants