Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return summer workshops in order of start date #32640

Merged
merged 1 commit into from
Jan 13, 2020

Conversation

bencodeorg
Copy link
Contributor

@bencodeorg bencodeorg commented Jan 13, 2020

Description

Updates list of summer workshops shown to teachers using the "search for your regional partner by zip" page to sort by the start date of the workshop, not the date the workshop was created. There was already a method that does exactly what I wanted, so nothing new!

Testing story

Tested locally. Also looked to see if there's anywhere else that we call upcoming_summer_workshops and didn't find anything -- that said, a search for upcoming_summer_workshops didn't return its use in the serializer that is responsible for its behavior on this page, which I don't understand.

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find!

@bencodeorg bencodeorg merged commit 4886a99 into staging Jan 13, 2020
@bencodeorg bencodeorg deleted the partner-zip-search-workshop-order branch January 13, 2020 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants