Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Application Dashboard: Show total application count #32645

Merged
merged 2 commits into from
Jan 15, 2020
Merged

Application Dashboard: Show total application count #32645

merged 2 commits into from
Jan 15, 2020

Conversation

islemaster
Copy link
Contributor

Adds a row for the total application count (per-course) to the Teacher Application Dashboard summary view, since partners occasionally check this total.

Suggested this change myself after answering a question for a partner and realizing our UI could do more to minimize confusion.

The total given here is a simple sum of the rows above, computed on the client. Note that we'll have issues later if the statuses given here aren't mutually exclusive (right now, it looks like they are).

Before After
before Screenshot from 2020-01-13 13-17-43

Testing story

Checked locally. I haven't written an automated test for this yet... I probably should.

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@islemaster
Application Dashboard: Show total application count
e91021e 
Adds a row for the total application count (per-course) to the Teacher
Application Dashboard summary view.

The total given here is a simple sum of the rows above, computed on the
client.
@islemaster islemaster added the feature New behavior label Jan 13, 2020
@islemaster islemaster requested a review from a team January 13, 2020 21:33
agealy
agealy approved these changes Jan 13, 2020
View reviewed changes
Copy link

@agealy agealy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat. Mutual exclusivity is a part of my mental model for application status, so I'm not too concerned with running into that problem.

breville
breville approved these changes Jan 14, 2020
View reviewed changes
Copy link
Member

@breville breville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any test coverage for this component?

@islemaster
Copy link
Contributor Author

There is now!

@breville
Copy link
Member

Nice!

@islemaster islemaster merged commit e5e519d into staging Jan 15, 2020
@islemaster islemaster deleted the total-applications branch January 15, 2020 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breville breville breville approved these changes

@agealy agealy agealy approved these changes

Assignees
No one assigned
Labels
feature New behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@islemaster @breville @agealy