FreeResponse levels have translated instructions. #32650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daynew
force-pushed
the
fnd-772-free-response-level-i18n
branch
from
327edeb
to
f4614bc
Compare
bethanyaconnor
approved these changes
Jan 14, 2020
* Issue: FreeResponse levels were not showing translated instructions even though translations existed. * Cause: FreeResponse levels not using the I18n API for content. * Fix: Update the `long_instructions` to be grabbed using the I18n API. * Also added new string: free_response.placeholder which will allow translators to translate the text "Enter your answere here".
daynew
force-pushed
the
fnd-772-free-response-level-i18n
branch
from
f4614bc
to
abd3e49
Compare
|
I have fixed the UI tests:
|
| def get_property(property_name) | ||
| # Return the default English string from the database model if we shouldn't | ||
| # localize this property or we couldn't find a localized value. | ||
| default = try(property_name) |
There was a problem hiding this comment.
Ah we moved the source of truth for some levels to the DB because we didn't want to upload everything to Crowdin iirc.
Hopefully as part of a shared API we can define where the English source strings for all levels...
|
Pulled and tested locally and it looks good! I don't love the fact that the source of truth is different for different levels but definitely a followup (that I believe you already filed). |
bethanyaconnor
approved these changes
Jan 15, 2020
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue: FreeResponse levels were not showing translated
instructions even though translations existed.
Cause: FreeResponse levels not using the I18n API for content.
Fix: Update the
long_instructionsto be grabbed using the I18n API.free_response.placeholderstring so we can translate the default placeholder text "Enter your answer here"Links
Follow-up work
Screenshots
Before
Note that the "Make a prediction..." text is not translated to Japanese.
After
Testing story
./bin/dashboard-serverReviewer Checklist: