Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add curriculum.code.org to allowed hostnames for doc proxy #32658

Merged
merged 1 commit into from
Jan 14, 2020

Conversation

ajpal
Copy link
Contributor

@ajpal ajpal commented Jan 14, 2020

Description

We got several reports of issues showing docs on levels
image
The issue seems to be how we proxy between studio.code.org, docs.code.org, and curriculum.code.org.
Targeted fix for now to just allow curriculum.code.org as a hostname, with a more comprehensive fix coming later.
See also: https://codedotorg.slack.com/archives/C0T0PNTM3/p1579018531110000

Testing story

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@ajpal ajpal changed the title add curriculum.code.org to allowed hostnames Add curriculum.code.org to allowed hostnames for doc proxy Jan 14, 2020
@ajpal ajpal merged commit 57b85cb into staging Jan 14, 2020
@ajpal ajpal deleted the jan14-curriculum branch January 14, 2020 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant