Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display null, undefined, "" in Applab Data Table #32663

Merged
merged 1 commit into from Jan 15, 2020
Merged

Conversation

ajpal
Copy link
Contributor

@ajpal ajpal commented Jan 14, 2020

Description

Currently all these values display as blank, but we want to show them separately so that students can tell what's actually in their table. This will also be important for the data visualizer work, which allows students to filter by specific value. For this, they will be able to be filter separately by "", null, or undefined, so it's important that they be able to tell what the actual value is in the table view.

Before:
image

After:
image

This change also applies to key/value pairs (undefined is not possible here)
image
image

Testing story

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

return 'null';
} else if (val === undefined) {
return 'undefined';
} else {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think JSON.Stringify('') returns "''" (hard to see that but it quotes the quote) - is that intended here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, I think yes. Lots of open questions still about how to correctly parse user input.
But just to keep things moving for dataviz, I think we can punt on some of those questions for now.

@ajpal ajpal merged commit 292f964 into staging Jan 15, 2020
@ajpal ajpal deleted the jan14-blanks branch January 15, 2020 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants