Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[student-libraries] Refactor the library creation dialog in preparation for adding 'unpublish' functionality #32792

Merged
merged 5 commits into from Jan 23, 2020
Merged

[student-libraries] Refactor the library creation dialog in preparation for adding 'unpublish' functionality #32792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b3ed974
Refactor in preparation for importing data from already-published lib…
jmkulwik Jan 11, 2020
d35963f
Updated tests for refactor
jmkulwik Jan 17, 2020
3d446c1
Updated for comments from the code review
jmkulwik Jan 22, 2020
9abfe4d
Some more fixes for tests
jmkulwik Jan 22, 2020
2d1fc80
Updates from CR
jmkulwik Jan 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/i18n/common/en_us.json
View file
Open in desktop
Expand Up @@ -831,7 +831,7 @@
"libraryExportTitle": "Export Functions as a Library",
"libraryName": "Library Name",
"libraryNameRequirements": "Your library's name must start with a capital letter and use only letters, numbers, and underscores.",
"libraryNoFunctonsError": "We can't publish your library because it doesn't have any functions. Try writing a function to include in your library.",
"libraryNoFunctionsError": "We can't publish your library because it doesn't have any functions. Try writing a function to include in your library.",
"libraryPublishExplanation": "Share this ID with others so they can use your library in their project:",
"libraryPublishInvalid": "Your library must include a description and at least one function.",
"libraryPublishFail": "There was an error publishing your library. Please check your internet connection and try again.",
Expand Down
2 changes: 1 addition & 1 deletion apps/src/code-studio/components/ShareAllowedDialog.jsx
View file
Open in desktop
Expand Up @@ -500,7 +500,7 @@ class ShareAllowedDialog extends React.Component {
)}
</BaseDialog>
<PublishDialog />
<LibraryCreationDialog clientApi={libraryClientAPI} />
<LibraryCreationDialog libraryClientApi={libraryClientAPI} />
</div>
);
}
Expand Down