Convert DSL to markdown part 2/3 #32802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsbailey
approved these changes
Jan 22, 2020
dmcavoy
approved these changes
Jan 23, 2020
| @@ -1,5 +1,6 @@ | |||
| name 'Commute Assess - comp 2 - block' | |||
| question 'The procedure <span style="font-family: monospace">op4</span> takes in 3 numbers, what does this procedure do?' | |||
| editor_experiment '' | |||
There was a problem hiding this comment.
Probably not an issue but wanted to call out this was added on this level but not the ones below which are the same level just for different years
There was a problem hiding this comment.
this looks like my bug -- editor_experiment shouldn't be getting added when the value is nil/empty. not sure what could be causing the difference though
There was a problem hiding this comment.
the difference is just that I edited the first one in my local levelbuilder interface so I could verify the results, then copied the changes into the other files using my text editor
|
Oh, weird; I'm not sure why those got skipped when I generated the list. But I did indeed check them manually myself, and they're fine. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the process of removing HTML from DSL fields:
This PR updates several levels whose use of HTML can be approximately converted to markdown. Most of these updates result in minor visual changes. Some examples are below.
pretags updated to usecodetagsVerification Links
Following is a list of all levels updated by this PR, and a link to that level on an adhoc. The list can be used to verify that the visual changes are acceptable.