[DataViz] Implement exact-match filter #32818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
215
to
220
| expect( | ||
| wrapper.instance().filterRecords(records, 'filterCol', '123') | ||
| ).to.deep.equal([ | ||
| {id: 1, filterCol: 123, chartCol: 2}, | ||
| {id: 3, filterCol: 123, chartCol: 5} | ||
| ]); |
There was a problem hiding this comment.
we should be able to simplify these all of the expect statements for this to something like:
expect(
wrapper.instance().filterRecords(records, 'filterCol', '123')
).to.deep.equal([records[0], records[2]]);
Comment on lines
+208
to
+214
| let records = [ | ||
| {id: 1, filterCol: 123, chartCol: 2}, | ||
| {id: 2, filterCol: 456, chartCol: 3}, | ||
| {id: 3, filterCol: 123, chartCol: 5}, | ||
| {id: 4, filterCol: '456', chartCol: 7}, | ||
| {id: 5, filterCol: 0, chartCol: 5} | ||
| ]; |
There was a problem hiding this comment.
since we're using this array everywhere, should we hoist this to the top of this describe block and merge all of the separate instances of records into a single array?
There was a problem hiding this comment.
It has different values for different tests, though. I think I prefer having a shorter list of records for each test rather than one big list to cover all tests. IMO that has the added benefit to readability of being able to see the test data and expected result in one place, rather than having to scroll back and forth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, exact-match filter only explicitly supports strings, numbers, booleans,
null, and,undefined. It is possible to have other values (such as objects or arrays) in a data table, but filtering in those cases is currently intentionally unspecified behavior.#32693 populates the first dropdown with the column names, and the second with all values in the selected column.
If both dropdowns have a value selected, we perform an exact match filter on the records
If you select filter options such that there is nothing to chart, we show a blank chart:
Links
Testing story
Reviewer Checklist: