Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display spinner/error on library import failure #32824

Merged
merged 5 commits into from Jan 24, 2020
Merged

Display spinner/error on library import failure #32824

merged 5 commits into from Jan 24, 2020

Conversation

maddiedierker
Copy link
Contributor

@maddiedierker maddiedierker commented Jan 23, 2020 •
edited

Adds the following to the "Import Library from ID" section of the "Manage Libraries" dialog:

  • A spinner while the library is being imported
  • An error when the library fails to import. The error is generic right now, but I have logged follow-up work to make this error more user-friendly and actionable.

Video of new behavior -- note that this video has an outdated error string. The image below has the most up-to-date string.

Screen Shot 2020-01-23 at 3 34 47 PM

Links

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@maddiedierker maddiedierker requested a review from a team as a code owner January 23, 2020 00:49
@maddiedierker maddiedierker merged commit 71152a4 into staging Jan 24, 2020
@maddiedierker maddiedierker deleted the import-invalid-lib branch January 24, 2020 00:44
@maddiedierker maddiedierker mentioned this pull request Mar 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajpal ajpal ajpal approved these changes

Assignees
No one assigned
Labels
star-labs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maddiedierker @ajpal