Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pin size for locations with multiple workshops #32910

Merged

Conversation

bencodeorg
Copy link
Contributor

My recent change to pin sizes on the CSF workshop map resulted in locations with multiple workshops that included a deep dive workshop remaining in the original size:

image

Now, pins are all the same size (intro, deep dive, combination of workshops):

image

Testing story

Tested locally per screenshot above, but no automated tests for this.

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@bencodeorg bencodeorg requested a review from a team January 29, 2020 21:58
}
return 'https://maps.google.com/mapfiles/kml/paddle/red-blank.png';
}
const iconForSubject = subject => ({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Can you just do { instead of ({?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did struggle with the syntax here, but the internet suggested that I needed to use parentheses to return an object literal from an arrow function. Happy to adjust to style standards though!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, interesting!

@bencodeorg bencodeorg merged commit fa3eef2 into staging Jan 30, 2020
@bencodeorg bencodeorg deleted the fix-csf-pin-size-multiple-workshops-same-location branch January 30, 2020 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants