Add subtitle and 'functions' section descriptions #32919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajpal
reviewed
Feb 13, 2020
| "libraryExportTitle": "Export Functions as a Library", | ||
| "libraryFunctionRequirements": "Select the functions you want to add to the library. To help understand what the function is for, you may only export functions that have a comment directly above them in your code.", |
There was a problem hiding this comment.
I'm guessing these strings came from product, so feel free to ignore, but "to help understand" seems like kind of odd phrasing. Whose understanding? Is it "to help importers of your library understand" or is it "to help you understand"?
There was a problem hiding this comment.
yeah, moneppo reached out to the curriculum team about this, but i haven't heard back about it, so i'm just merging this work to unblock any upcoming work in this area
ajpal
approved these changes
Feb 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two pieces of text to the library export dialog:
Links
Testing story
Manually tested this change, but did not add any automated tests as it's a content addition with no conditional logic.
Reviewer Checklist: