Add links to facilitator landing pages based on course you facilitate #32936
Conversation
dmcavoy
requested review from
Erin007,
hacodeorg and
a team
and removed request for
hacodeorg
|
Updated (@hacodeorg )
|
|
|
||
| -if courses_facilitated.include? Pd::Workshop::COURSE_CSF | ||
| %a{href: "https://curriculum.code.org/plcsf/", target: '_blank'} | ||
| %h3 |
There was a problem hiding this comment.
I guess we use heading styles to make these links look big, and it's certainly an existing pattern, but these are usually not really headings, so I think it would be better if we could make a new CSS class and use that for all of these.
There was a problem hiding this comment.
I'm going to leave the styling as is for now and let the PLC team decide how you would like this area to be styled going forward.
| %h3 | ||
| CSF Facilitator Landing Page | ||
| -if courses_facilitated.include? Pd::Workshop::COURSE_CSD | ||
| %a{href: "https://curriculum.code.org/plcsd/", target: '_blank'} |
There was a problem hiding this comment.
I feel like we should be using a helper function (or Rails route) to refer to "https://curriculum.code.org" rather than literally mentioning it multiple times. Amongst other advantages, it would make it much easier to change this domain in the future in one place, and also to link to a variation of it for different environments such as "staging" and "test"...
There was a problem hiding this comment.
I see your point but I'm going to leave it here since there are already lots of specific references to curriculum.code.org. Instead I will take a work item as part of platformization stuff to do this clean up.
Right now facilitators just need to memorize the link to their landing pages on Curriculum builder such as curriculum.code.org/plcsp/ for CSP facilitators. This figures out which courses you facilitate and adds the links for your facilitator landing pages to the bottom of your homepage along with the links to the Workshop Dashboard.
The below example is a facilitator for CSF and CSD but not CSP.