DTL (Test > Levelbuilder): 79d46e53 #32969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes two issues when using fallback video in the popup video player on dashboard: - Notes were showing below the dialog, not inside it, because we weren't hiding the fallback video when changing to the notes tab. - The fallback video was extending below the bottom of the dialog in some cases, because the caption link was being added using React, but wasn't visible when we calculated the dialog dimensions.
This change is borrowed from the unmerged #8611.
The dashboard and pegasus video players already support a `force_youtube_fallback` URL parameter to force the fallback player to run. Now, they also support a `force_youtube_player` URL parameter to force YouTube to run. This might be useful for diagnosing video player issues in the future, for example if the fallback detection kicks in too aggressively because the user is on a particularly slow connection.
Remove https://studio.code.org/videos/test. It wasn't especially useful for diagnosing video issues, particularly we couldn't access submissions to the form any more. Also update https://code.org/educate/it.
This fixes levels such as /s/oceans video levels which use a large-sized video player, so that they have large video again, and not a 100px x 100px video. It also removes the blue glow on the entire video when it gets focus. Details: - Use CSS class "vjs-fill" to make video take up all space when width & height are 100%. - Don't set width/height dimensions of 100% since they seem to be converted to 100px. - Remove focus glow on entire poster (before video starts) and entire video (after video starts). Leave new focus glow in place for other video player buttons since they probably help with accessibility. But the two we removing it for don't seem to be in the tab order.
The download icon on pegasus' popup video player was squished, low resolution, and misaligned. It's now improved.
Video.js otherwise has an issue on iOS where returning to inline from the default fullscreen player shows two sets of control UI: Video.js' and the native video player's on top.
Native controls for touch should avoid the problem of having both VideoJS and native controls drawn after returning from fullscreen fallback player.
Native controls for touch should avoid the problem of having both VideoJS and native controls drawn after returning from fullscreen fallback player.
Just like dashboard fallback player already has.
This is consistent with styling done for fallback player focus on dashboard.
… basis for this view in order to capture a row for teachers who start teaching but only in a year later than the one they were trained in [ci skip]
Rp view updates [ci skip]
DTT (Staging > Test) [robo-dtt]
Video player: upgrade dashboard video.js to 7.6.6
…eo-js Video player: upgrade pegasus video.js to 7.6.6 #32803
Video players: allow force-YouTube URL parameter
Video players: remove test page
…d-icon Video player: fix download icon on pegasus
DTT (Staging > Test) [Brendan]
…ss-tab Standards by Script for Progress Tab
DTT (Staging > Test) [robo-dtt]
DTS (Levelbuilder > Staging) [robo-dts]
Conflicts: locals.yml.default
[student libraries] Disabled cloud front caching and some browser caching for library GET requests.
Update sprite manifests to use new api endpoint
DTT (Staging > Test) [robo-dtt]
Followup to #32732. [ci skip]
Add environment tag to data stack
Remove copying files print lines
DTT (Staging > Test) [robo-dtt]
…er-options Document Geocoder gem config/credentials in locals.yml.default
DTT (Staging > Test) [robo-dtt]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.