Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standards report: Print Report Pretty and Correct Info on Report #33014

Merged
merged 24 commits into from
Feb 11, 2020

Conversation

dmcavoy
Copy link
Contributor

@dmcavoy dmcavoy commented Feb 6, 2020

  1. Fix bug where if you switch scripts we did not reload the standards data for the new script in the standards tab.
  2. Hide the tooltips on the lesson boxes when you are viewing the standards table in the standards report.
  3. When you print the report most of the styling goes into the print view (the font seems to be the only thing that does not stay consistent).
  4. The correct information shows up in the standards report based on what script you have selected in teacher dashboard and the teacher comment input.

Links

Testing story

Tests:

  • Tooltip is hidden when viewing standards report
  • UI test for Standards View and Report Generation
  • Update StandardsReport Unit tests based on the changes to use window.opener to pass information

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@dmcavoy dmcavoy requested a review from a team as a code owner February 6, 2020 15:36
@dmcavoy dmcavoy changed the base branch from staging to standards-report-part2 February 6, 2020 15:37
@dmcavoy dmcavoy changed the title Standards report part3 Standards report: Print Report Pretty and Correct Info on Report Feb 8, 2020
@dmcavoy dmcavoy changed the base branch from standards-report-part2 to staging February 10, 2020 19:26
@dmcavoy dmcavoy merged commit 691b88d into staging Feb 11, 2020
@dmcavoy dmcavoy deleted the standards-report-part3 branch February 11, 2020 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants