Log thread backtraces and GC stats for app debugging #33027
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Three changes in this PR:
LogAppStats
) to log app stats every second across all worker processes for debugging purposes, that can be dynamically switched on/off by a flag.before_fork
code to (re-)launch DCDO and Gatekeeper update-threads in the parent. This fixes a bug where DCDO/Gatekeeper entries were not getting updated in the daemonized parent process in cluster (workers
> 0) + daemon (-d
) mode.Testing Story
Manual testing on an adhoc to confirm the logging and dynamic configuration work as expected. No automated testing at this point since the instrumentation was developed quickly, and intended to be enabled only for temporary/debugging purposes.